This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
feat: ✨ changed error response to success flag #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordany33
temporarily deployed
to
staging-134
GitHub Actions
Inactive
jordany33
temporarily deployed
to
staging-134-docs
GitHub Actions
Inactive
ecxyzzy
suggested changes
Mar 9, 2024
There was a problem hiding this comment.
Sorry for my late response.
Just adding success: boolean to BaseResponse doesn't actually work, as the checks show, because RawResponse<T> needs to be a tagged union. Should be a relatively straightforward fix, but let me know if you have any issues.
jordany33
temporarily deployed
to
staging-134-docs
GitHub Actions
Inactive
jordany33
temporarily deployed
to
staging-134-docs
GitHub Actions
Inactive
ecxyzzy
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #115